Conversation
|
@akorosov @aperrin66 I delete the whole nansat_ingestor app in b90668a because we have developed localharvester in the harvesting repo! :) |
aperrin66
left a comment
aperrin66
left a comment
There was a problem hiding this comment.
- Removing
nansat_ingestorshould be in a different pull request. - There are still references to
geospaas.urlsin the repository
| gg, created = GeographicLocation.objects.get_or_create(geometry=WKTReader().read(geom_wkt)) | ||
| gg, created = GeographicLocation.objects.get_or_create(geometry=WKTReader().read(geom_wkt)) |
There was a problem hiding this comment.
If the error due to max precision does not happen anymore, this test can probably be deleted.
Or maybe it still happens with a particular database backend?
Even if it is the case, I am not sure if we should keep that test, since it does not validate a desired behavior.
Maybe it would be more relevant to create an issue about this problem, describing steps to reproduce it.
There was a problem hiding this comment.
I haven't seen this error myself. However the test can remain here.
What's needed:
- rename the test to reflect that
not_null_constraint_failedis not reproduced anymore - add a relevant comment that db actually can handle high precision numbers
|
@aperrin66 ok! by the last four commits I dont do anything regarding nansat_ingestor here. I will do it in another PR. |
which references do you mean @aperrin66 ? |
|
in geospaas.rst file? |
Among others, you can just look for the "geospaas.urls" string in django-geo-spaas to find them. |
akorosov
left a comment
akorosov
left a comment
There was a problem hiding this comment.
Minor correction to the test__reproduce__not_null_constraint_failed() test
3 participants
removing geospaas.urls.py as mentioned in #126