Improve KeyPadButton text style resolution #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the text style resolution logic in
KeyPadButtonConfig
to properly handle merging of custom button text styles with the default composed text style.Changes
toButtonStyle()
methodProblem Solved
Previously, when custom button styles were provided via
buttonStyle
, the resultantKeyPadButton
's text style ignores user providedbuttonStyle.textStyle
and only usescomposed.textStyle
which may result in inconsistent UI. This change ensures that:buttonStyle
are properly merged with the default composed text stylefontFamily
)Testing
This change improves the flexibility and reliability of text style customization for KeyPad buttons.