Skip to content

Fix for handcoded timeout values in SRLAPI #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellt merged 4 commits into from
Nov 22, 2025
Merged

Fix for handcoded timeout values in SRLAPI #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41c2287
fix for issue 62.
Nov 21, 2025
4e505f9
trailing whitespace cleanup.
Nov 21, 2025
ce36c11
Update python versions runs in line with napalm github
Nov 21, 2025
ec7de9b
Updating missing python 3.13 tag
Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ jobs:
strategy:
max-parallel: 5
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] # in line with Napalm base project
# Python Version Updated in line with napalm project.
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
Expand Down
6 changes: 3 additions & 3 deletions napalm_srl/srl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
Napalm driver for SR Linux.

Read https://napalm.readthedocs.io for more information.
"""
"""
import base64
import json
import logging
Expand Down Expand Up @@ -89,7 +89,7 @@ def __init__(self, hostname, username, password, timeout=60, optional_args=None)
self._channel = None
self.running_format = optional_args.get("running_format","json") if optional_args else "json"

self.device = SRLAPI(hostname, username, password, timeout=60, optional_args=optional_args)
self.device = SRLAPI(hostname, username, password, timeout=timeout, optional_args=optional_args)

self.pending_commit = False
# Whether to save changes to startup config, default False
Expand Down Expand Up @@ -2458,7 +2458,7 @@ def __init__(self, hostname, username, password, timeout=60, optional_args=None)

if not self.insecure:
if not self.tls_ca:
logging.warning( "Incompatible settings: insecure=False " +
logging.warning( "Incompatible settings: insecure=False " +
"requires certificate parameter 'tls_ca' to be set " +
"when using self-signed certificates" )

Expand Down