refactor: Implement type-safe configuration using generated string literals#412
Open
Mopsgamer wants to merge 11 commits intonarcisbugeag:mainfrom
Open
refactor: Implement type-safe configuration using generated string literals#412Mopsgamer wants to merge 11 commits intonarcisbugeag:mainfrom
Mopsgamer wants to merge 11 commits intonarcisbugeag:mainfrom
Conversation
Contributor
Author
|
I believe this PR makes the configuration migration for #151 more automated and seamless. It's ready for review. |
move src/configtype.ts to src/@types/configtypes.d.ts
Mopsgamer
changed the title
Mopsgamer
commented
Feb 16, 2026
| const config = getConfig(); | ||
| const currentState = CONFIG_KEYS.Status.Buttons[currentButton]; | ||
| const configKeyEnabled = | ||
| isGit && state != "Inactive" ? currentState.Git[state].Enabled : currentState[state].Enabled; |
Contributor
Author
There was a problem hiding this comment.
Using state != "Inactive" here feels strange.
Mopsgamer
commented
Feb 16, 2026
|
|
||
| let workspaceExcludedText = "No workspace ignore text provided."; | ||
| const ignoreWorkspacesText = config.get(CONFIG_KEYS.Ignore.WorkspacesText)!; | ||
| const ignoreWorkspacesText = config.get("vscord.ignore.workspacesText") ?? ""; |
Contributor
Author
There was a problem hiding this comment.
there are multiple uses of !, and it feels buggy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving toward string literals and generated types, we eliminate "magic strings" and provide better IDE autocompletion and compile-time validation for our application settings.