Skip to content

chore: import Listnamespace from compliant #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoGorelli merged 2 commits into from
Jan 16, 2026
Merged

chore: import Listnamespace from compliant #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78810e1
import Listnamespace from compliant
ym-pett Jan 16, 2026
65ffc2d
adding not_implemented methods to silence typing error
ym-pett Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion narwhals_daft/expr_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

import daft.functions as F
from daft import lit
from narwhals._compliant.any_namespace import ListNamespace
from narwhals._utils import not_implemented
from narwhals.compliant import ListNamespace

if TYPE_CHECKING:
from daft import Expression
Expand Down
2 changes: 2 additions & 0 deletions narwhals_daft/expr_str.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,5 @@ def replace_all(self, value: DaftExpr, pattern: str, *, literal: bool) -> DaftEx
contains = not_implemented()
to_datetime = not_implemented()
zfill = not_implemented()
pad_start = not_implemented()
pad_end = not_implemented()