Skip to content

feature: Implement to_string in expr_dt#83

Merged
MarcoGorelli merged 3 commits intonarwhals-dev:mainfrom
ym-pett:implement_to_string
Dec 8, 2025
Merged

feature: Implement to_string in expr_dt#83
MarcoGorelli merged 3 commits intonarwhals-dev:mainfrom
ym-pett:implement_to_string

Conversation

@ym-pett
Copy link
Collaborator

@ym-pett ym-pett commented Dec 8, 2025

linked to #35

daft plays nicely with Narwhals on this one!

please note: I had to manually choose the tests to remove in run_tests.py, as python update_run_tests.py added lots of tests back in that we'd already removed and didn't remove the relevant tests. I don't quite understand why, maybe it's because locally I'd branched off the wrong branch to start with in the PR?

Let me know if this should be investigated as part of this PR. I'm tempted to think it's some leftover mess on my local version that will sort itself out with the next pull from main.

I did to the usual:

git fetch upstream
git reset --hard upstream/main

@ym-pett ym-pett marked this pull request as ready for review December 8, 2025 10:37
@ym-pett ym-pett changed the title Implement to string feature: Implement to string Dec 8, 2025
@ym-pett ym-pett changed the title feature: Implement to string feature: Implement to_string in expr_dt Dec 8, 2025
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Dec 8, 2025

thanks!

you might have missed git submodule update --init --recutsive after git pull?

@MarcoGorelli MarcoGorelli merged commit 3677c57 into narwhals-dev:main Dec 8, 2025
2 checks passed
@ym-pett
Copy link
Collaborator Author

ym-pett commented Dec 8, 2025

aahhh that was exactly it, thanks for reminding me! you've unblocked me on the next PR I believe

@ym-pett ym-pett deleted the implement_to_string branch December 8, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants