feature: Implement to_string in expr_dt#83
Merged
MarcoGorelli merged 3 commits intonarwhals-dev:mainfrom Dec 8, 2025
Merged
Conversation
Member
Collaborator
Author
|
aahhh that was exactly it, thanks for reminding me! you've unblocked me on the next PR I believe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

linked to #35
daft plays nicely with Narwhals on this one!
please note: I had to manually choose the tests to remove in
run_tests.py, aspython update_run_tests.pyadded lots of tests back in that we'd already removed and didn't remove the relevant tests. I don't quite understand why, maybe it's because locally I'd branched off the wrong branch to start with in the PR?Let me know if this should be investigated as part of this PR. I'm tempted to think it's some leftover mess on my local version that will sort itself out with the next pull from main.
I did to the usual: