Skip to content

chore: Use shiny's Makefile to allow for test commands to change over time #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2024
Merged

chore: Use shiny's Makefile to allow for test commands to change over time #1161

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
288de19
Use shiny's Makefile to allow for test commands to change over time
schloerke Oct 10, 2024
45aa57f
Remove white space
schloerke Oct 11, 2024
480c666
Update step name
schloerke Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/workflows/downstream_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,11 @@ jobs:
- name: install-basics
run: uv pip install --upgrade tox virtualenv setuptools --system
- name: install-shiny-dev
env:
UV_SYSTEM_PYTHON: 1
run: |
cd py-shiny
uv pip install -e ".[dev,test]" --system
make narwhals-install-shiny
- name: install-narwhals-dev
run: |
uv pip uninstall narwhals --system
Expand All @@ -125,10 +127,4 @@ jobs:
- name: Run pytest
run: |
cd py-shiny
python tests/pytest/asyncio_prevent.py
pytest
- name: Run mypy
run: |
cd py-shiny
uv pip install mypy --system
mypy shiny
make narwhals-test-integration
Loading