Skip to content

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Mar 11, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Temporarily ignoring new typing errors that appeared after https://github.com/eakmanrq/sqlframe/releases/tag/v3.24.0

@dangotbanned dangotbanned changed the title fix(typing): Generic SparkLikeLazyFrame fix(typing): Resolve sqlframe>=3.24.0 errors Mar 11, 2025
@dangotbanned
Copy link
Member Author

dangotbanned commented Mar 11, 2025

@MarcoGorelli it is starting to look like I need to touch most of the SparkLike* annotations and add @overload(s) to fix this in-place.
Pretty much every Column needs some extra complexity

I just wanna float the idea of adding # pyright: ignore[...](s) on the current issues and holding off on fixing for now?

main already has problems like this which will be fixed by #2149:

class SparkLikeExpr(CompliantExpr["SparkLikeLazyFrame", "Column"]): # type: ignore[type-var] # (#2044)
_depth = 0 # Unused, just for compatibility with CompliantExpr

I feel like we'd be in a better position to decide on what route to take on #2185 after that PR is merged.


I'm still open to doing it another way if you have a preference πŸ™‚

@MarcoGorelli
Copy link
Member

I just wanna float the idea of adding # pyright: ignore... on the current issues and holding off on fixing for now?

yeah, sure

@dangotbanned dangotbanned force-pushed the typing-sqlframe-3.24.0 branch from 6a9c09f to 01830c1 Compare March 11, 2025 13:28
@dangotbanned
Copy link
Member Author

I just wanna float the idea of adding # pyright: ignore... on the current issues and holding off on fixing for now?

yeah, sure

Thanks @MarcoGorelli!

@dangotbanned dangotbanned reopened this Mar 11, 2025
@dangotbanned dangotbanned changed the title fix(typing): Resolve sqlframe>=3.24.0 errors chore(typing): Resolve sqlframe>=3.24.0 errors Mar 11, 2025
@dangotbanned dangotbanned marked this pull request as ready for review March 11, 2025 13:39
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dangotbanned dangotbanned merged commit e64efb6 into main Mar 11, 2025
58 of 60 checks passed
@dangotbanned dangotbanned deleted the typing-sqlframe-3.24.0 branch March 11, 2025 13:41
dangotbanned added a commit to MarcoGorelli/narwhals that referenced this pull request Mar 12, 2025
- Added in narwhals-dev#2187, narwhals-dev#2051
- No longer needed since `sqlframe` only typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants