Skip to content

chore(typing): add missing _FullContext to CompliantDataFrame #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

chore(typing): add missing _FullContext to CompliantDataFrame #2251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7f438a
chore(typing): add missing `_FullContext` to `CompliantDataFrame`
dangotbanned Mar 19, 2025
1b9c815
Merge branch 'main' into compliant-df-context
dangotbanned Mar 19, 2025
cd5363d
Merge branch 'main' into compliant-df-context
dangotbanned Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions narwhals/_compliant/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ class CompliantDataFrame(
Protocol[CompliantSeriesT, CompliantExprT_contra, NativeFrameT_co],
):
_native_frame: Any
_implementation: Implementation
_backend_version: tuple[int, ...]
_version: Version
Comment on lines +53 to +55
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was pretty surprised that I didn't need to change anything outside of the protocol

Looks like everyone was already compliant 😄


def __narwhals_dataframe__(self) -> Self: ...
def __narwhals_namespace__(self) -> Any: ...
Expand Down
Loading