-
Notifications
You must be signed in to change notification settings - Fork 170
refactor: Add CompliantDataFrame.from_dict
#2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1bb5615
feat(typing): Add `DictConvertible` protocol
dangotbanned be8713f
feat(typing): Add `CompliantFrame.from_dict`
dangotbanned d851993
feat: Add `PolarsDataFrame.from_dict`
dangotbanned 69da9d4
feat: Add `ArrowDataFrame.from_dict`
dangotbanned 434a309
refactor: Use `Table.from_pydict` instead
dangotbanned 346c259
feat: Add `PandasLikeDataFrame.from_dict`
dangotbanned 682439e
chore: Include `Version` in private signatures
dangotbanned f14a05e
refactor: Update `_from_dict_impl`
dangotbanned 836038f
refactor: Split out `_from_dict_no_backend`
dangotbanned d9bf5bd
fix: `3.8` compat
dangotbanned 9470e6f
Merge remote-tracking branch 'upstream/main' into df-from-dict
dangotbanned 94a13f9
perf: Skip `from_native` when we know `PandasLikeSeries`
dangotbanned 56a7222
fix: version
dangotbanned File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This diff π»π» |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok on a serious not, do you have any resource to learn this the right way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha I guess I'll take that as a compliment π
But I'm not sure I know what you mean @FBruzzesi - could you explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The easiness with which you are able to introduce and combine typevar's and classes to make all the types coherent - I want to learn that π‘
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FBruzzesi ah that π
Well I suppose a lot of it is just putting in the time battling it out with
mypy&pyrightuntil things stick.The most exhaustive resource would be the typing spec.
I use that whenever I come across a message/concept I'm not familiar with.
If you use VSCode, I strongly recommend enabling the inlay hints settings for
Pylance.When in doubt, you can just omit/delete an annotation and see what
pyrighthas inferred it to be.That usually helps nudge me towards solving an issue - if that doesn't match what I expected.
I'll try to have a think on it tomorrow if there's anything else I can shareβΊοΈ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inlay hints
Now that I think about it, it must seem strange that I rarely annotate variables π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's nice! just enabled it, thanks!