chore: Transition selectors away from Protocol38
#2326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to untangle `CompliantExpr` + friends #2294 (comment)
dangotbanned
commented
Apr 1, 2025
Comment on lines
+112
to
+115
| EvalSeries: TypeAlias = Callable[ | ||
| [CompliantFrameT], Sequence[CompliantSeriesOrNativeExprT] | ||
| ] | ||
| EvalNames: TypeAlias = Callable[[CompliantFrameT], Sequence[str]] |
There was a problem hiding this comment.
Hoping to use these more now that they're not defined in selectors.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
EagerSeries*Namespaceprotocols #2294 (comment)CompliantSelector#2064Compliant(When|Then)#2261Checklist
If you have comments or can explain your changes, please do so below
Follow-up to this big writeup (#2294 (comment))
SelectorsNamespacenow uses the regularProtocolclass.CompliantSelectoris ready to change, butCompliantExprneeds switching over first