Skip to content

feat!: disallow concat(..., how="horizontal") for LazyFrame #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 10, 2025
Merged

feat!: disallow concat(..., how="horizontal") for LazyFrame #2341

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1c195fe
feat: disallow how=horizontal for lazy concat
MarcoGorelli Apr 4, 2025
5211a03
stable api docstring
MarcoGorelli Apr 4, 2025
f981dee
coverage
MarcoGorelli Apr 4, 2025
648f9e4
Merge remote-tracking branch 'upstream/main' into disallow-lazy-horiz…
MarcoGorelli Apr 5, 2025
fdd966f
Merge remote-tracking branch 'upstream/main' into disallow-lazy-horiz…
MarcoGorelli Apr 9, 2025
d053845
skip hist_test for now
MarcoGorelli Apr 10, 2025
ee52813
test: try an `xfail` instead of `skip`
dangotbanned Apr 10, 2025
13b0fb1
test: be more specific
dangotbanned Apr 10, 2025
f1938d6
refactor: Reuse `is_narwhals_lazyframe`
dangotbanned Apr 10, 2025
0dd9cc2
docs: big F
dangotbanned Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/series_only/hist_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
from tests.utils import ConstructorEager
from tests.utils import assert_equal_data

pytest.skip(
reason="https://github.com/narwhals-dev/narwhals/issues/2348", allow_module_level=True
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli if this cleans up CI (and you're not planning to merge this PR today) could you split the fix into a tiny PR please? 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always worried I'll miss something when there's existing CI issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe an xfail will save us from https://github.com/narwhals-dev/narwhals/actions/runs/14376119881/job/40308843895?pr=2341

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe an xfail will save us from narwhals-dev/narwhals/actions/runs/14376119881/job/40308843895?pr=2341

It did 😁 (ee52813)

data = {
"int": [0, 1, 2, 3, 4, 5, 6],
}
Expand Down
Loading