Skip to content

chore(typing): More isinstance_or_issubclass overloads #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2025
Merged

chore(typing): More isinstance_or_issubclass overloads #2731

merged 2 commits into from
Jun 25, 2025

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Jun 25, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

While I was looking for unreachable code, I noticed some isinstance_or_issubclass cases were marked incorrectly as unreachable.
They are reachable, but when I wrote (#1997) we only had up to a 3-tuple.
The current max of 7 wasn't covered, so this PR fixes that

Before 1

image

After 1

image

Before 2

image

After 2

image

@dangotbanned
chore(typing): More isinstance_or_issubclass overloads
dbb42ab 
- Related (#2717)

While I was looking for unreachable code, I noticed some `isinstance_or_issubclass` cases were marked as unreachable.
They *are* reachable, but when I wrote (#1997) we only had up to a **3**-tuple.
The current max of **7** wasn't covered, so this PR fixes that
@dangotbanned dangotbanned marked this pull request as ready for review June 25, 2025 10:02
MarcoGorelli
MarcoGorelli approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna trust you on this one 😄 thanks!

@MarcoGorelli MarcoGorelli merged commit 6a8bbfe into main Jun 25, 2025
32 checks passed
@MarcoGorelli MarcoGorelli deleted the more-overloads-isinstance_or_issubclass branch June 25, 2025 17:20
dangotbanned added a commit that referenced this pull request Sep 18, 2025
@dangotbanned
refactor(typing): Remove now-unused isinstance_or_issubclass overloads
7eddd96 
- Full revert of #2731
- Not needed since #2969

Now, we only have 1 case which uses the 2x `@overload`(s) but I'm keeping the 3x as well for now 🙂
@dangotbanned dangotbanned mentioned this pull request Sep 18, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees

No one assigned

Labels

internal typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dangotbanned @MarcoGorelli