-
Notifications
You must be signed in to change notification settings - Fork 168
feat: Use _repr_html_ when native supports it
#2776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dangotbanned
wants to merge
21
commits into
main
Choose a base branch
from
df-repr-html
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
9ad45ba
feat: Use `_repr_html_` when native supports it
dangotbanned 04e1f51
Merge branch 'main' into df-repr-html
dangotbanned bf7e87a
Merge branch 'main' into df-repr-html
dangotbanned edb7ae4
Merge remote-tracking branch 'upstream/main' into df-repr-html
dangotbanned 3769326
feat: Support `pl.LazyFrame._repr_html_`
dangotbanned 3559cf8
Merge remote-tracking branch 'upstream/main' into df-repr-html
dangotbanned ea42e83
chore: add note on testing
dangotbanned 3748f23
feat: Support `pl.Series._repr_html_`
dangotbanned 5bb73d8
Merge branch 'main' into df-repr-html
dangotbanned e77c8de
Merge branch 'main' into df-repr-html
dangotbanned d8f09a4
Merge branch 'main' into df-repr-html
dangotbanned 4227f10
Merge branch 'main' into df-repr-html
dangotbanned 690e6e4
Merge branch 'main' into df-repr-html
dangotbanned 6f2ab6b
Merge branch 'main' into df-repr-html
dangotbanned 61497d6
Merge branch 'main' into df-repr-html
dangotbanned c4dca25
Merge remote-tracking branch 'upstream/main' into df-repr-html
dangotbanned f73d564
Merge branch 'main' into df-repr-html
dangotbanned e32e139
Merge remote-tracking branch 'upstream/main' into df-repr-html
dangotbanned 57e333d
rename `header` -> `caption_text`
dangotbanned 7758265
change `caption-side` to `top`
dangotbanned dfb5f5e
Merge remote-tracking branch 'upstream/main' into df-repr-html
dangotbanned File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else in this function is a new language to me - I am not very helpful
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah
xml.etree.elementtreeis a bit of a strange oneI had to learn a bit of
lxmlonce to fix a particularly broken file.The API of that is based on this stdlib module, but was more ergonoic than this mess π
To simplify this:
So I'm essentially doing a fancy find/replace, but trying to preserve the structure of the document