Skip to content

chore: Refactor _apply_exprs_function internal #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

chore: Refactor _apply_exprs_function internal #2829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions narwhals/_pandas_like/group_by.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,13 @@ def _apply_exprs_function(self, exprs: Iterable[PandasLikeExpr]) -> NativeApply:
into_series = ns._series.from_iterable

def fn(df: pd.DataFrame) -> pd.Series[Any]:
out_group = []
out_names = []
for expr in exprs:
results_keys = expr(self.compliant._with_native(df))
for keys in results_keys:
out_group.append(keys.native.iloc[0])
out_names.append(keys.name)
compliant = self.compliant._with_native(df)
results = (
(keys.native.iloc[0], keys.name)
for expr in exprs
for keys in expr(compliant)
)
out_group, out_names = zip(*results) if results else ([], [])
return into_series(out_group, index=out_names, context=ns).native

return fn
Expand Down
Loading