-
Notifications
You must be signed in to change notification settings - Fork 170
feat: Add support for nw.int_range for eager backends
#2895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FBruzzesi
wants to merge
71
commits into
main
Choose a base branch
from
feat/int-range
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
cd8b49d
Eager mode
FBruzzesi 74b94c1
lazy WIP
FBruzzesi 81f12fa
merge main
FBruzzesi c775ccd
fixed eager
FBruzzesi b3ba810
add docs, cleanse a bit
FBruzzesi 9ee6209
fix or ignore typing issues
FBruzzesi a3496ed
skip if impl not installed
FBruzzesi dc263c8
overloads?
FBruzzesi f612646
fix overloads
FBruzzesi 5a46579
merge main and add to v2
FBruzzesi b8b6ae2
add in v2.__all__
FBruzzesi 22c52eb
factor out _native_int_range into utils
FBruzzesi 8f4f647
resolve majority of typing and import issues
FBruzzesi 7fb18bb
replace all type hints with IntegerDType, ignore import in functions
FBruzzesi dde4a99
Dan's suggestion
FBruzzesi 876a771
refactor: Remove unused `IntegerType`
dangotbanned 5ddd072
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned 5eeda2d
refactor: Reuse a single `Implementation.PYARROW._backend_version()`
dangotbanned 704da84
fix(typing): Kinda fix `_native_int_range`
dangotbanned 7ec01e0
refactor: Add `int64`
dangotbanned 57393ec
fix(typing): make marco's checker happy π
dangotbanned f1857f8
refactor(typing): Omit defaults in overloads
dangotbanned c94b4d4
refactor(typing): Remove unreached overload
dangotbanned fe2bc9d
refactor(typing): rinse/repeat for stable
dangotbanned fc29864
refactor: fix `polars` typing, use kwargs when required
dangotbanned 749edfc
chore(typing): Remove unused asserts
dangotbanned 4706a30
test: Add failing `Expr` + `eager` case
dangotbanned 1be56cc
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned bc0355f
low hanging feedback adjustments
FBruzzesi 352fd4f
refactor into int_range_eager
FBruzzesi 8b195ba
typo
FBruzzesi 466d85d
forgot to mention about eager value in suggestion
FBruzzesi 1575ae8
ci: Update `dtypes-import`
dangotbanned 82e93fa
refactor: Add `PandasLikeNamespace._array_funcs`
dangotbanned 2c52f91
refactor(suggestion): Move impl to `EagerNamespace.int_range`
dangotbanned f13d667
defaults for `int_range` as well
dangotbanned 447a276
refactor: Use `_series`, pass `dtype_pa` once
dangotbanned 1673573
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned 1098afb
revert: Undo `Int64` hack
dangotbanned 15ae42a
refactor: Use `int_range_eager` in `with_row_index`
dangotbanned 71e9856
always require `Expr` in `CompliantNamespace.int_range`
dangotbanned f3387c0
Update narwhals/functions.py
FBruzzesi 8367cc2
Merge branch 'main' into feat/int-range
FBruzzesi c8af149
chore: Note remaining `np.arange` usage
dangotbanned ea155ca
tag as unstable
FBruzzesi 77eb2bd
Merge branch 'main' into feat/int-range
FBruzzesi 4c949e6
Merge branch 'main' into feat/int-range
dangotbanned c430d5b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3b96967
Merge branch 'main' into feat/int-range
FBruzzesi c98740b
Merge branch 'main' into feat/int-range
dangotbanned a7d4e25
Merge branch 'main' into feat/int-range
dangotbanned 190590b
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned cf5799a
Merge branch 'main' into feat/int-range
FBruzzesi f7e5c9a
Merge branch 'main' into feat/int-range
dangotbanned 5c7e6e6
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned 5484863
Merge branch 'main' into feat/int-range
dangotbanned ec5ee4b
Merge branch 'main' into feat/int-range
dangotbanned 813c101
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned 9584b0f
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned 7e81d46
Merge branch 'main' into feat/int-range
dangotbanned 0c6495f
refactor(typing): Use `IntoBackend[EagerAllowed]`
dangotbanned 45cf54a
docs: Remove Returns sections
dangotbanned abe3da7
merge main
FBruzzesi fb4cfda
Merge branch 'main' into feat/int-range
dangotbanned e8739e5
Merge branch 'main' into feat/int-range
dangotbanned 1d8602b
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned fb6c328
fix: Update for (#3045)
dangotbanned 35ece71
fix: Don't treat `step` as an `Expr`
dangotbanned afd35f6
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned 0de173e
chore(typing): fix incompatible override
dangotbanned 80c422a
Merge remote-tracking branch 'upstream/main' into feat/int-range
dangotbanned File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.