-
Notifications
You must be signed in to change notification settings - Fork 170
chore: fixup operator type ignores for SQLExpr
#2920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 35 commits into
narwhals-dev:main
from
ym-pett:fix_sql_operator_problem
Aug 8, 2025
Merged
Changes from 5 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
40e1737
temp fix to type problem
ym-pett a8af821
notes on what should happen
ym-pett f8e853c
corrected base class
ym-pett fda9a7d
wip experimenting with methods
ym-pett 86ed14a
wip improved types
ym-pett ec08949
wip operator
ym-pett a4de0bb
wip operator: added thoughts
ym-pett d372db6
wip operator: modified Self import
ym-pett 3a97dcb
wip operator: added thoughts & only using in sqrt
ym-pett 9a544e8
wip operator: more comments, going back to reading
ym-pett 266cab9
wip operator: fixed NativeSQLExprT bound
ym-pett 4aae069
wip operator: adding NativeSQLExprT to get rid of operator issue
ym-pett 7ad112a
wip operator: added all changes from pair session, 1 problem remaining
ym-pett 937e2a1
checkpoint
ym-pett 854e2f3
joy: only 1 type error to go
ym-pett 0fa44af
Merge branch 'main' into fix_sql_operator_problem
ym-pett a2deceb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a9cabad
silencing ibisexpr type error
ym-pett a2c4f31
correcting error silencing
ym-pett dea1fe2
adding extra dunder methods
ym-pett 27e748f
removed leftover comment
ym-pett 495fb11
wip: trying to move operators into NativeExpr
ym-pett 9383492
move to NativeExpr works
ym-pett df82744
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c65df29
Merge branch 'main' into fix_sql_operator_problem
ym-pett dd39727
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 09731da
removing commented out
ym-pett b4b48d9
trying to silence ibis type errors
ym-pett a131d51
annoying stray comment
ym-pett 3521336
Merge branch 'main' into fix_sql_operator_problem
ym-pett dcf1b80
fix(suggestion): Remove problematic protocol members
dangotbanned e6f7640
took out wip comment
ym-pett 5347b9f
Merge branch 'main' into fix_sql_operator_problem
ym-pett b17d241
Merge branch 'main' into fix_sql_operator_problem
ym-pett 462cf8a
remove `isin`
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the return type should be
Selfwhen you do arithmetic / comparisons between these expressions, the output is still an expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thanks for that, now I understand why
Self!