test(typing): Avoid masking fixed overloads #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed during the series of PRs that ended at #2944
- Each was only ever a single type - The remaining one in `dtypes_test` is still helpful, since we assign multiple times using incompatible nominal types
dangotbanned
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
DataFrame,LazyFrame#2944NativeSeriesProtocol #2159Checklist
If you have comments or can explain your changes, please do so below
I have no idea what to title this PR 😂
During another PR I noticed some strange typing that I think was masking the problems resolved recently in the
from_nativeoverloads.So, I've removed/corrected some annotations that had
FrameorIntoSeries.Important
We should not need to annotate inline when handling the return of a
narwhalsfunctionThat indicates an issue with our typing to fix