Skip to content

Conversation

@dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Sep 5, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

CuDF is closer to cuDF than Cudf πŸ™‚

Aligns with the spelling used for these, which came before the aliases in (2ad79a9)

class _CuDFDataFrame(_BasePandasLikeFrame, Protocol):
def to_pylibcudf(self, *args: Any, **kwds: Any) -> Any: ...
class _CuDFSeries(_BasePandasLikeSeries, Protocol):
def to_pylibcudf(self, *args: Any, **kwds: Any) -> Any: ...

_NativeCuDF: TypeAlias = "_CuDFDataFrame | _CuDFSeries"

@overload
@classmethod
def from_native_object(
cls, native: _NativeCuDF, /
) -> Namespace[PandasLikeNamespace[_CuDFDataFrame, _CuDFSeries]]: ...

- Follow-up to #3016
- Doesn't quite fit into #3086
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dangotbanned

@FBruzzesi FBruzzesi merged commit 9ca3602 into main Sep 6, 2025
30 of 31 checks passed
@FBruzzesi FBruzzesi deleted the rename-cudf-cudf branch September 6, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants