-
Notifications
You must be signed in to change notification settings - Fork 175
chore: pandas-nightly and duckdb-nightly fixes #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pandas-nightly and duckdb-nightly fixes #3158
Conversation
4c2cbb7 to
6bdd28f
Compare
|
Alright only 5 test failures left |
narwhals/_duckdb/utils.py
Outdated
| dtypes.Int32: duckdb_dtypes.INTEGER, | ||
| dtypes.Int64: duckdb_dtypes.BIGINT, | ||
| dtypes.Int128: DuckDBPyType("INT128"), | ||
| dtypes.Int128: duckdb_dtypes.DuckDBPyType("INT128"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
| dtypes.Int128: duckdb_dtypes.DuckDBPyType("INT128"), | |
| dtypes.Int128: duckdb_dtypes.HUGEINT, |
(and dtypes.UInt128: duckdb_dtypes.UHUGEINT, below)?
| echo "$DEPS" | grep 'duckdb==1.1' | ||
| - name: Run pytest | ||
| run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy] | ||
| run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow --constructors=pandas,pyarrow,polars[eager],polars[lazy],duckdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
FBruzzesi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MarcoGorelli - I am pretty onboarded with the duckdb changes.
Regarding pandas I can see we are adding yet another different behavior from polars and pandas pre v3. Is it really not feasible to remap one of the two behavior? e.g. pandas v2 to pandas v3 or pandas v3 to polars? Apologies if the answer to this is obvious, but I didn't even try it myself. And if the answer is negative, should we document in the null vs nan section the pandas v3 behavior?
|
thanks for your review! there's a whole discussion going on at pandas-dev/pandas#62040 π© not sure where things will end up, but i think we should wait until the next release before documenting the |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below