refactor(expr-ir): Split up and refine protocols.py
#3166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How `column` fits in with `expr` and `scalar` is still an open question Child of (#2572)
Gonna be soooooooo much easier to work on them side-by-side now 🥳
dangotbanned
changed the title
protocols.py
71 tasks
Discovered this convention *after* naming the original May as well differentiate better from the jump
The problem is that type checkers special-case `__init__` to allow covariance ... despite the same thing not being allowed on a classmethod (`from_<...>`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
ExprIR #2572If you have comments or can explain your changes, please do so below
Gonna be soooooooo much easier to work on them side-by-side now 🥳
Tasks
narwhals/narwhals/_plan/protocols.py
Line 1 in 53f4041
CompliantBaseFrameto be more like the upstreamed refactor: AddCompliantFrameprotocol #3056CompliantBaseFrame->CompliantFrame