-
Notifications
You must be signed in to change notification settings - Fork 170
perf: Add __slots__ to all DTypes
#3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+264
β90
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
819c564
perf: Add `__slots__` to all `DType`s
dangotbanned 2fe3d8c
fix: Ensure `__dict__` isn't created
dangotbanned aa29d41
fix: Rinse/repeat `v1` slots
dangotbanned 6dada91
test: Check `__dict__` is a no-no
dangotbanned 14be6e3
Merge branch 'main' into dtype-__slots__
dangotbanned b2f6976
add precommit check for slotted classes
FBruzzesi 7117d38
more explicit unpacking names
FBruzzesi 05db297
ci(ruff): Add (`T201`) ignore to all `utils/*`
dangotbanned e96f463
refactor(suggestion): Reuse `get_dtype_backend_test` logic
dangotbanned 06a8e54
merge main, solve conflicts
FBruzzesi 3795a49
fix: Include more than leaves, make sure in scope
dangotbanned d9c0520
perf: huge speedup
dangotbanned 28e3ef7
ci: Link to what `__slots__` even are
dangotbanned a404d0d
Even friendlier error message
dangotbanned File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.