chore: move tests to a narwhals-testing package#3475
Draft
tokoko wants to merge 2 commits intonarwhals-dev:mainfrom
Draft
chore: move tests to a narwhals-testing package#3475tokoko wants to merge 2 commits intonarwhals-dev:mainfrom
tokoko wants to merge 2 commits intonarwhals-dev:mainfrom
Conversation
Member
|
thanks for the pr - sure, seems like a good idea perhaps it's worth testing out in https://github.com/narwhals-dev/narwhals-daft to see if/how it would work there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR moves tests to a new package
narwhals-testing. The goal is to make it easier for plugins that live outside the main repo to easily hook into the tests defined here.I've yet to test that the change will indeed work on the plugin side, but wanted to first get the feedback here whether this seems like a right direction to you.