Skip to content

supercritical typos in README.md has been fixed as mentioned#2217

Merged
eereiter merged 5 commits intonasa:masterfrom
Brijeshthummar02:Brijeshthummar02-Readme-1
Mar 1, 2025
Merged

supercritical typos in README.md has been fixed as mentioned#2217
eereiter merged 5 commits intonasa:masterfrom
Brijeshthummar02:Brijeshthummar02-Readme-1

Conversation

@Brijeshthummar02
Copy link
Copy Markdown
Contributor

@Brijeshthummar02 Brijeshthummar02 commented Feb 17, 2025

Overview

fixes #2215

What is the feature/fix?

it fixes some of the mentioned Typos in Readme

Please summarize the feature or fix.

What is the Solution?

Summarize what you changed.

What areas of the application does this impact?

List impacted areas.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@Brijeshthummar02
Copy link
Copy Markdown
Contributor Author

@eereiter have a look, and if there are more changes that needs to be looked, do mention.

Copy link
Copy Markdown
Contributor

@eereiter eereiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording needs to change.

Copy link
Copy Markdown
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@Brijeshthummar02
Copy link
Copy Markdown
Contributor Author

@jceaser if it's good to go, we can merge it!

@Brijeshthummar02
Copy link
Copy Markdown
Contributor Author

@jmaeng72 can we merge it? Got approved by both Reviewers.

@Brijeshthummar02
Copy link
Copy Markdown
Contributor Author

@eereiter can we merge this PR????

@eereiter eereiter merged commit 752d8ea into nasa:master Mar 1, 2025
4 checks passed
@Brijeshthummar02 Brijeshthummar02 deleted the Brijeshthummar02-Readme-1 branch March 1, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

supercritical typos in README.md

3 participants