Skip to content

CMR-10313: Setup the bamboo builds - code changed as well as I needed to change the structure and added tests.#2218

Merged
eereiter merged 12 commits intomasterfrom
CMR-10313
Feb 26, 2025
Merged

CMR-10313: Setup the bamboo builds - code changed as well as I needed to change the structure and added tests.#2218
eereiter merged 12 commits intomasterfrom
CMR-10313

Conversation

@eereiter
Copy link
Copy Markdown
Contributor

Overview

What is the feature/fix?

Added bamboo tasks for http notification lambda and http notification test lambda. Reorganized some code, needed to update some code, and added tests.

What is the Solution?

Added bamboo tasks for http notification lambda and http notification test lambda. Reorganized some code, needed to update some code, and added tests.

What areas of the application does this impact?

Subscription notifications lambda and test lambda.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

Copy link
Copy Markdown
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things really. Just some feedback but the spelling errors must be fixed.

@eereiter eereiter merged commit ff3c7af into master Feb 26, 2025
6 checks passed
@eereiter eereiter deleted the CMR-10313 branch February 26, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants