Skip to content

CMR-10388: Add access control checks to the subscription worker to take out any notifications when the subscriber no longer has access.#2222

Merged
eereiter merged 30 commits intomasterfrom
CMR-10388
Feb 28, 2025
Merged

CMR-10388: Add access control checks to the subscription worker to take out any notifications when the subscriber no longer has access.#2222
eereiter merged 30 commits intomasterfrom
CMR-10388

Conversation

@eereiter
Copy link
Copy Markdown
Contributor

Overview

What is the feature/fix?

Add access control checks to the subscription worker to take out any notifications when the subscriber no longer has access.

What is the Solution?

Add access control checks to the subscription worker to take out any notifications when the subscriber no longer has access.

What areas of the application does this impact?

Subscription worker check permissions with access control.

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2025

Codecov Report

❌ Patch coverage is 20.83333% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.23%. Comparing base (ff3c7af) to head (7b92d30).
⚠️ Report is 192 commits behind head on master.

Files with missing lines Patch % Lines
...app/src/cmr/metadata_db/services/subscriptions.clj 25.00% 5 Missing and 10 partials ⚠️
...ueue-lib/src/cmr/message_queue/topic/aws_topic.clj 0.00% 2 Missing ⚠️
...ue-lib/src/cmr/message_queue/topic/local_topic.clj 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2222      +/-   ##
==========================================
- Coverage   58.23%   58.23%   -0.01%     
==========================================
  Files        1056     1056              
  Lines       71134    71142       +8     
  Branches     2062     2062              
==========================================
+ Hits        41427    41430       +3     
- Misses      27781    27784       +3     
- Partials     1926     1928       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update that URL

@eereiter eereiter merged commit 0515f3e into master Feb 28, 2025
6 checks passed
@eereiter eereiter deleted the CMR-10388 branch February 28, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants