CMR-10388: Add access control checks to the subscription worker to take out any notifications when the subscriber no longer has access.#2222
Conversation
TylerHeald1
reviewed
Feb 26, 2025
jmaeng72
reviewed
Feb 26, 2025
TylerHeald1
reviewed
Feb 26, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
- Coverage 58.23% 58.23% -0.01%
==========================================
Files 1056 1056
Lines 71134 71142 +8
Branches 2062 2062
==========================================
+ Hits 41427 41430 +3
- Misses 27781 27784 +3
- Partials 1926 1928 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jceaser
reviewed
Feb 27, 2025
jmaeng72
reviewed
Feb 27, 2025
metadata-db-app/test/cmr/metadata_db/test/services/subscriptions_test.clj
Outdated
Show resolved
Hide resolved
jmaeng72
reviewed
Feb 27, 2025
jmaeng72
reviewed
Feb 27, 2025
jmaeng72
reviewed
Feb 27, 2025
jmaeng72
reviewed
Feb 27, 2025
jmaeng72
reviewed
Feb 27, 2025
jmaeng72
reviewed
Feb 27, 2025
jceaser
approved these changes
Feb 28, 2025
TylerHeald1
approved these changes
Feb 28, 2025
jmaeng72
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature/fix?
Add access control checks to the subscription worker to take out any notifications when the subscriber no longer has access.
What is the Solution?
Add access control checks to the subscription worker to take out any notifications when the subscriber no longer has access.
What areas of the application does this impact?
Subscription worker check permissions with access control.
Checklist