CMR-9332: Fix lint issues for ACL libs

[DuJuan]

Overview

What is the feature/fix?

Resolves lint errors and warnings in ACL-related files, enhancing code quality and consistency across the codebase.

What is the Solution?

1. Updating naming conventions (e.g., changing 'acl_core' to 'acl-core')
2. Refactoring functions for better readability (e.g., search-for-groups, context->sids)
3. Using more idiomatic Clojure functions (e.g., zero?, pos?, not-any?)
4. Simplifying expressions and improving error handling
5. Updating test files to reflect changes and improve mock functions

What areas of the application does this impact?

• Access Control API routes
• ACL validation services
• ACL core functionality
• ACL-related test files

Checklist

• I have updated/added unit and int tests that prove my fix is effective or that my feature works
• New and existing unit and int tests pass locally and remotely
• clj-kondo has been run locally and all errors corrected
• I have removed unnecessary/dead code and imports in files I have changed
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have cleaned up integration tests by doing one or more of the following:

[eereiter]

The spacing is off for the routes.clj namespace.

[jceaser]

I think the questions on spacing need to be answered for routes.clj

[jmaeng72]

the spacing on this file is still off. Why is there a space in front of the func names?

[jmaeng72]

is there a unit test on this func that makes sure the functionality of it has not changed?

[jmaeng72]

let's have a chat about this, I think it would be easier than back and forth PR comments