Skip to content

CMR-10425: Update job-router libraries for use with python 3.13#2226

Merged
TylerHeald1 merged 13 commits intomasterfrom
CMR-10425
Mar 10, 2025
Merged

CMR-10425: Update job-router libraries for use with python 3.13#2226
TylerHeald1 merged 13 commits intomasterfrom
CMR-10425

Conversation

@TylerHeald1
Copy link
Copy Markdown
Contributor

Overview

What is the feature/fix?

version of Urllib3 needed to be updated to be used with Python 3.13

What is the Solution?

Urllib3 tracked version was removed so latest can be pulled in.
Also, some refactoring was done

What areas of the application does this impact?

job-router

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

Copy link
Copy Markdown
Contributor

@jceaser jceaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I requested changes before.

@TylerHeald1 TylerHeald1 merged commit 56bf291 into master Mar 10, 2025
6 checks passed
@TylerHeald1 TylerHeald1 deleted the CMR-10425 branch March 10, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants