Conversation
Update tests
Remove redundant resolution of includes This operation has been moved to the tools, along with adding state machine enums
Make the code robust to having an enumerated constant T
Revise ResolveSpecInclude Update tests
Add dependency from state machine to state machine enum Regenerate test output
Use State Machine enum to represent state
Add description of State enum
Collaborator
Author
|
I had to merge the issue 927 branch into this one. I pointed this PR to that branch to get an accurate diff comparison. |
Kronos3
reviewed
Mar 3, 2026
Collaborator
Kronos3
left a comment
Kronos3
left a comment
There was a problem hiding this comment.
This looks great. I have one minor comment
compiler/tools/fpp-to-cpp/test/state-machine/state/BasicGuardTestArrayStateMachineAc.ref.hpp
Show resolved
Hide resolved
Kronos3
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the State enum for state machines and revises the C++ code gen to match. This way we can use the state enum in FPP events and telemetry. Closes #615.
This PR also does the following:
Tcould shadow enumT.Tandem development for this PR is here: https://github.com/bocchino/fprime/tree/fpp-issue-615-sm-enum.