Conversation
jwest115
requested changes
Mar 9, 2026
compiler/tools/fpp-to-cpp/test/top/tlm_packets/NoInstances_P1TlmPacketsAc.ref.cpp
Outdated
Show resolved
Hide resolved
jwest115
approved these changes
Mar 10, 2026
Ensure that status is returned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following in
tools/fpp-to-cpp/test:test/fprimeinstead of using ad-hoc definitions. This makes the code gen more consistent, because all framework dependencies use the same header files.topto move individual tests into subdirectories. This makes the test code more modular and scalable.toptests to cover events, telemetry, data products, and typed ports. These are needed for the upcoming work on direct port calls.