Update fw_testing pytest integration to include using default configuration file#286
Open
bevinduckett wants to merge 5 commits intonasa:develfrom
Open
Update fw_testing pytest integration to include using default configuration file#286bevinduckett wants to merge 5 commits intonasa:develfrom
bevinduckett wants to merge 5 commits intonasa:develfrom
Conversation
Updated ConfigDrivenParser to always check & give preference to the environment variable setting the configuration path . Also updated the class to add a function to the command line options from the config file without needing to parse all the options
Moved checking the FPRIME_GDS_CONFIG_PATH environment variable from this file into the ConfigDrivenParser class
thomas-bc
reviewed
Feb 26, 2026
| if dictionaries.constant_name: | ||
| for name, value in dictionaries.constant_name.items(): | ||
| config.set_constant(name, value) | ||
| args.dictionaries = dictionaries |
Collaborator
There was a problem hiding this comment.
This blob of change looks like a recent change has been reverted - you likely branched off before it was made. Could we revert it back to the current devel state?
thomas-bc
requested changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
fprime_test_api_sessioninpytest_integration.pyto include default GDS configuration using the ConfigDrivenParser classFPRIME_GDS_CONFIG_PATHas part of its default behavior (previously the default file path was included in the class implementation but the environment variable override of that path was only checked in run_deployment.py)Rationale
The rationale for updating
fprime_test_api_sessionwas so that runningpytestwould pick up the same GDS defaults asfprime-gds- without that feature in my environment, we'd need to have a bunch of different pytest configuration files to ensure the correct dictionary got used for different deployments being testedUpdating the ConfigDrivenParser class was required to avoid environment variable name that could override the default configuration path being specified and handled in multiple locations (previously only in run_deployment.py, but the updates to pytest_integration.py would've also required it)
Testing/Review Recommendations
To test:
Future Work
Note any additional work that will be done relating to this issue.