DAS-2437 Configure geographic spatial extent for SMAP polar grids#66
DAS-2437 Configure geographic spatial extent for SMAP polar grids#66sudha-murthy merged 8 commits intomainfrom
Conversation
D-Auty
left a comment
There was a problem hiding this comment.
I've reviewed the updates in coding and unit tests.
It is Interesting that the addition of a geographic spatial extent configuration item, and its use to constrain the spatial extent of the granule data, revealed a flaw in the cropping of the spatial constraint points. When the spatial constraint is entirely outside the granule's extent, the constraint cannot be cropped and the "invalid-request" exception (no-data-found), has to be raised early in the request processing flow.
lyonthefrog
left a comment
There was a problem hiding this comment.
I ran the unit tests, allll the regression tests, and the three requests here in the PR. All pass, but the last PR request (South BBox) passes with a no data warning - is that expected?
I made one tiny comment, but other than that it looks great!
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - SMAP Polar data subsetting constrained to North of Equator. |
There was a problem hiding this comment.
Little thing - I don't think "polar" and "north" need to be capitalized here.
Description
Adds configuration to limit SMAP polar grids to the northern hemisphere as the granules only have fills in the southern hemisphere.
Jira Issue ID
DAS-2437
Local Test Steps
All tests should pass
Test Instructions:
All the following requests should pass and the polar grid outputs should only be in the northern hemisphere in all cases.
North Box
http://localhost:3000/C1268617120-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&granuleId=G1268617167-EEDTEST&subset=lat(38.0%3A68.0)&subset=lon(12.0%3A36.0)&variable=Freeze_Thaw_Retrieval_Data_Global%2Fsurface_flag&variable=Freeze_Thaw_Retrieval_Data_Polar%2Fsurface_flag
North and South BBox
http://localhost:3000/C1268617120-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&granuleId=G1268617167-EEDTEST&subset=lat(-38.0%3A68.0)&subset=lon(12.0%3A36.0)&variable=Freeze_Thaw_Retrieval_Data_Global%2Fsurface_flag&variable=Freeze_Thaw_Retrieval_Data_Polar%2Fsurface_flag&
South BBox
http://localhost:3000/C1268617120-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&granuleId=G1268617167-EEDTEST&subset=lat(-38.0%3A-28.0)&subset=lon(12.0%3A36.0)&variable=Freeze_Thaw_Retrieval_Data_Global%2Fsurface_flag&variable=Freeze_Thaw_Retrieval_Data_Polar%2Fsurface_flag&
PR Acceptance Checklist
CHANGELOG.mdupdated to include high level summary of PR changes.docker/service_version.txtupdated if publishing a release.