Skip to content

DAS-2437 Configure geographic spatial extent for SMAP polar grids#66

Merged
sudha-murthy merged 8 commits intomainfrom
DAS-2437
Jan 27, 2026
Merged

DAS-2437 Configure geographic spatial extent for SMAP polar grids#66
sudha-murthy merged 8 commits intomainfrom
DAS-2437

Conversation

@sudha-murthy
Copy link
Copy Markdown
Contributor

@sudha-murthy sudha-murthy commented Jan 16, 2026

Description

Adds configuration to limit SMAP polar grids to the northern hemisphere as the granules only have fills in the southern hemisphere.

Jira Issue ID

DAS-2437

Local Test Steps

  • Fetch the branch
  • Run bin/build-image & bin/build-test & bin/run-test
    All tests should pass
  • All harmony regression tests for hoss should pass
  • das harmony regressions tests for hoss for SMAP collections should pass
  • NSIDC harmony smap regression tests should pass

Test Instructions:
All the following requests should pass and the polar grid outputs should only be in the northern hemisphere in all cases.

  1. North Box
    http://localhost:3000/C1268617120-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&granuleId=G1268617167-EEDTEST&subset=lat(38.0%3A68.0)&subset=lon(12.0%3A36.0)&variable=Freeze_Thaw_Retrieval_Data_Global%2Fsurface_flag&variable=Freeze_Thaw_Retrieval_Data_Polar%2Fsurface_flag

  2. North and South BBox
    http://localhost:3000/C1268617120-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&granuleId=G1268617167-EEDTEST&subset=lat(-38.0%3A68.0)&subset=lon(12.0%3A36.0)&variable=Freeze_Thaw_Retrieval_Data_Global%2Fsurface_flag&variable=Freeze_Thaw_Retrieval_Data_Polar%2Fsurface_flag&

  3. South BBox
    http://localhost:3000/C1268617120-EEDTEST/ogc-api-coverages/1.0.0/collections/parameter_vars/coverage/rangeset?forceAsync=true&granuleId=G1268617167-EEDTEST&subset=lat(-38.0%3A-28.0)&subset=lon(12.0%3A36.0)&variable=Freeze_Thaw_Retrieval_Data_Global%2Fsurface_flag&variable=Freeze_Thaw_Retrieval_Data_Polar%2Fsurface_flag&

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).
  • Jira ticket updated with expected fixversion hoss-X.Y.Z

@sudha-murthy sudha-murthy marked this pull request as ready for review January 22, 2026 23:37
@sudha-murthy sudha-murthy requested a review from a team as a code owner January 22, 2026 23:37
Copy link
Copy Markdown

@D-Auty D-Auty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the updates in coding and unit tests.

It is Interesting that the addition of a geographic spatial extent configuration item, and its use to constrain the spatial extent of the granule data, revealed a flaw in the cropping of the spatial constraint points. When the spatial constraint is entirely outside the granule's extent, the constraint cannot be cropped and the "invalid-request" exception (no-data-found), has to be raised early in the request processing flow.

Copy link
Copy Markdown
Contributor

@lyonthefrog lyonthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the unit tests, allll the regression tests, and the three requests here in the PR. All pass, but the last PR request (South BBox) passes with a no data warning - is that expected?

I made one tiny comment, but other than that it looks great!

CHANGELOG.md Outdated

### Changed

- SMAP Polar data subsetting constrained to North of Equator.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little thing - I don't think "polar" and "north" need to be capitalized here.

@sudha-murthy sudha-murthy merged commit d767e3d into main Jan 27, 2026
4 checks passed
@sudha-murthy sudha-murthy deleted the DAS-2437 branch January 27, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants