Harmony 1978 - Add/create label from jobs page of workflow ui#681
Merged
vinnyinverso merged 39 commits intomainfrom Jan 28, 2025
Merged
Harmony 1978 - Add/create label from jobs page of workflow ui#681vinnyinverso merged 39 commits intomainfrom
vinnyinverso merged 39 commits intomainfrom
Conversation
Contributor
chris-durbin
left a comment
chris-durbin
left a comment
There was a problem hiding this comment.
Tested out locally. The basic functionality looks good and works as expected. There were a few things I found when testing:
- When creating a new label that label is not immediately available in the auto-complete for the filter box (on the left side of the page). Reloading the page makes that label available.
- I pasted in text that would have resulted in more than 255 characters, but my label was created successfully. I'm guessing it must have truncated? It's probably worth a message in the toast if it truncated the label to 255 characters.
- Filtering on a really long label leads to text that crosses the full width of the screen.
- Attempting to filter on a really long label isn't working (the results are not filtered).
3 and 4 are unrelated to this PR - probably should open a bug ticket.
TODO - with long label + commas: (1) toast is cut off, (2) label with comma is being split in view, (3) can search for label filter but not use it when pressing enter
TODO - large label should be truncated in filtering dropdown
TODO: typing "," should not cause tag to be entered in input
…rom different field?
TODO: Clean up naming, duplication, ensure bug isn't found elsewhere too
Contributor
Author
|
I addressed feedback numbers 1-4 and a couple of related issues. |
indiejames
reviewed
Jan 27, 2025
Contributor
indiejames
left a comment
indiejames
left a comment
There was a problem hiding this comment.
Tested locally. Verified that new labels are available in filtering without reloading page. Also verified that new labels are bing limited to 255 characters (with warning if you try to go over).
indiejames
approved these changes
Jan 27, 2025
chris-durbin
approved these changes
Jan 28, 2025
Contributor
chris-durbin
left a comment
chris-durbin
left a comment
There was a problem hiding this comment.
Verified everything is working as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1978
Description
Allows the user to add/create a label from jobs page of workflow ui.
Local Test Steps
PR Acceptance Checklist