Skip to content

Ldds 528#690

Merged
chris-durbin merged 8 commits intonasa:mainfrom
cbrownstevenson:LDDS-528
Feb 11, 2025
Merged

Ldds 528#690
chris-durbin merged 8 commits intonasa:mainfrom
cbrownstevenson:LDDS-528

Conversation

@cbrownstevenson
Copy link
Copy Markdown

@cbrownstevenson cbrownstevenson commented Feb 5, 2025

Jira Issue ID

Objective: https://bugs.earthdata.nasa.gov/browse/LDDS-528

Description

  • Add dimension/L1b band subsetting to subset-band-name
  • Service chain subset-band-name in geoloco's service and turn on band subsetting

Local Test Steps

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)
  • Harmony in a Box tested? (if changes made to microservices)

@cbrownstevenson
Copy link
Copy Markdown
Author

I re-added variable subsetting to geoloco in CMR UAT but do not know how to re-kick off the test.

Copy link
Copy Markdown
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check the output from the compare-services script which is currently failing to make sure your UMM-S record and harmony configuration match.

Also I think you can remove the ldds/subset-band-name service chain. The Geoloco chain can support everything you need once you make the steps conditional based on the transformations requested by the user.

- image: !Env ${QUERY_CMR_IMAGE}
is_sequential: true
- image: !Env ${SUBSET_BAND_NAME_IMAGE}
is_sequential: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one should be marked as sequential. Sequential is for something like query-cmr with pages through CMR results and can possibly create additional work items for the same step as part of its process.

I believe you'll want to make this step optional though. For example if a user does not ask for variable subsetting I think you want to skip subset-band-name and go straight to Geoloco. I'm not sure what other operations subset-band-name performs besides variable subsetting.

Something like:

        conditional:
          exists: ['variableSubset']

Similarly are there ever cases where you would only want to perform Geoloco and not subset-band-name? You would want to add a conditional for it as well.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the variableSubset include dimension subsetting? Or do I add something like dimensionSubset?

Copy link
Copy Markdown
Author

@cbrownstevenson cbrownstevenson Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Found my answer.

@cbrownstevenson
Copy link
Copy Markdown
Author

Double-check the output from the compare-services script which is currently failing to make sure your UMM-S record and harmony configuration match.

Also I think you can remove the ldds/subset-band-name service chain. The Geoloco chain can support everything you need once you make the steps conditional based on the transformations requested by the user.

@chris-durbin I removed it before I learned how service chaining worked. I added variable subsetting back in after looking at the check results.

Christine Brown-Stevenson and others added 3 commits February 6, 2025 15:08
Copy link
Copy Markdown
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-durbin chris-durbin merged commit 563ea3d into nasa:main Feb 11, 2025
2 checks passed
@cbrownstevenson cbrownstevenson deleted the LDDS-528 branch February 11, 2025 15:22
@cbrownstevenson cbrownstevenson restored the LDDS-528 branch February 11, 2025 15:22
@cbrownstevenson cbrownstevenson deleted the LDDS-528 branch March 10, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants