Conversation
…vices with pixelSubset parameter.
This was referenced Feb 20, 2025
chris-durbin
approved these changes
Feb 24, 2025
Contributor
chris-durbin
left a comment
There was a problem hiding this comment.
Tested successfully locally - I verified using the workflow_steps table in the database that the operation had the correct value for each of the three requests:
- no pixelSubset in request
- pixelSubset set to false
- pixelSubset set to true
indiejames
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1965
Description
Add support of pixelSubset parameter to harmony transformation endpoints.
There are corresponding changes in harmony-service-lib-py and harmony-service-example projects.
Local Test Steps
Check out
harmony-service-exampleandharmony-service-lib-pyprojects on branchharmony-1965.Add
logger.warn(f'incoming message: {message}')on line 80 ofharmony_service_example/transform.pyto log the service message that is submitted ot the service.Build harmony-service-example with the harmony-service-lib-py locally (i.e.
make build-image LOCAL_SVCLIB_DIR=../harmony-service-lib-py).Build all harmony images and run
bin/bootstrap-harmonySubmit the following requests:
http://localhost:3000/C1233800302-EEDTEST/ogc-api-coverages/1.0.0/collections/blue_var/coverage/rangeset?subset=lat(20%3A60)&subset=lon(-140%3A-50)&granuleId=G1233800343-EEDTEST&outputCrs=EPSG%3A31975&format=image%2Fpng
http://localhost:3000/C1233800302-EEDTEST/ogc-api-coverages/1.0.0/collections/blue_var/coverage/rangeset?subset=lat(20%3A60)&subset=lon(-140%3A-50)&granuleId=G1233800343-EEDTEST&outputCrs=EPSG%3A31975&format=image%2Fpng&pixelSubset=false
http://localhost:3000/C1233800302-EEDTEST/ogc-api-coverages/1.0.0/collections/blue_var/coverage/rangeset?subset=lat(20%3A60)&subset=lon(-140%3A-50)&granuleId=G1233800343-EEDTEST&outputCrs=EPSG%3A31975&format=image%2Fpng&pixelSubset=true
Verify the incoming message logged in harmony-service-example log shows pixelSubset in message as
None,False,Truerespectively.Also test EDR requests similarly, e.g.
http://localhost:3000/ogc-api-edr/1.1.0/collections/C1233800302-EEDTEST/cube?bbox=-140,20,-50,60&granuleId=G1233800343-EEDTEST&crs=EPSG%3A31975&f=image%2Fpng&datetime=1975-01-02T00%3A00%3A00Z%2F2020-01-02T01%3A00%3A00Z&pixelSubset=true
PR Acceptance Checklist