Conversation
…that indicates that a result contains no data.
chris-durbin
approved these changes
Feb 28, 2025
indiejames
approved these changes
Feb 28, 2025
Contributor
indiejames
left a comment
There was a problem hiding this comment.
Tested locally (hiab as well as dev) and in sandbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1995
Description
As a user, I want Harmony to handle service a response that indicates that a result contains no data.
Local Test Steps
Modify harmony-service-example to create nodata warnings for specific granules to facilitate with the testing. e.g. add
from harmony_service_lib.exceptions import NoDataExceptionat the top and the following to around line 98 oftransform.pyin harmony-service-example:to simulate two nodata warnings for the first two granules in this harmony request:
http://localhost:3000/C1233800302-EEDTEST/ogc-api-coverages/1.0.0/collections/red_var,blue_var,green_var/coverage/rangeset/?subset=lat(20%3A60)&subset=lon(-140%3A-50)&outputCrs=EPSG%3A31975&format=image%2Fpng&maxResults=3
You can simulate the entire job's work items all have nodata warnings or a single nodata warning error by changing the
maxResultsto 2 or 1. And feel free to test with chains with multiple services.PR Acceptance Checklist