Merge pull request #770 from nasa/dev

Release 1.7.3

Author: John P. Lucas

.clang-format

@@ -0,0 +1,64 @@
+---
+Language:        Cpp
+AccessModifierOffset: -4
+AlignAfterOpenBracket: Align
+AlignConsecutiveAssignments: true
+AlignConsecutiveDeclarations: true
+AlignConsecutiveMacros: true
+AlignEscapedNewlines: Left
+AlignOperands:   true
+AlignTrailingComments: true
+AllowAllParametersOfDeclarationOnNextLine: true
+AllowShortBlocksOnASingleLine: Empty
+AllowShortCaseLabelsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: Empty
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+AlwaysBreakAfterReturnType: None
+AlwaysBreakBeforeMultilineStrings: false
+BinPackArguments: true
+BinPackParameters: true
+BreakBeforeBinaryOperators: None
+BreakBeforeBraces: Allman
+BreakBeforeTernaryOperators: true
+BreakStringLiterals: true
+ColumnLimit:     120
+CommentPragmas:  ''
+ContinuationIndentWidth: 4
+Cpp11BracedListStyle: true
+DerivePointerAlignment: false
+DisableFormat:   false
+ExperimentalAutoDetectBinPacking: false
+ForEachMacros: []
+IncludeBlocks:   Preserve
+IncludeCategories:  []
+IncludeIsMainRegex: '$'
+IndentCaseLabels: true
+IndentPPDirectives: None
+IndentWidth:     4
+KeepEmptyLinesAtTheStartOfBlocks: true
+MacroBlockBegin: ''
+MacroBlockEnd:   ''
+MaxEmptyLinesToKeep: 1
+PenaltyBreakAssignment: 2
+PenaltyBreakBeforeFirstCallParameter: 19
+PenaltyBreakComment: 300
+PenaltyBreakFirstLessLess: 120
+PenaltyBreakString: 1000
+PenaltyExcessCharacter: 1000000
+PenaltyReturnTypeOnItsOwnLine: 60
+PointerAlignment: Right
+ReflowComments:  true
+SortIncludes:    false
+SpaceAfterCStyleCast: false
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeParens: ControlStatements
+SpaceInEmptyParentheses: false
+SpaceBeforeCpp11BracedList: true
+SpacesBeforeTrailingComments: 1
+SpacesInCStyleCastParentheses: false
+SpacesInParentheses: false
+SpacesInSquareBrackets: false
+Standard:        c++11
+TabWidth:        8
+UseTab:          Never

.github/ISSUE_TEMPLATE/1-BUG_REPORT.yml

@@ -1,62 +1,33 @@
-name: "🐛 Bug Report"
+name: "Bug Report"
 description: Create a new ticket for a bug.
-title: "🐛 [BUG] - <title>"
 labels: [
-  "bug"
+  "Bug"
 ]
 body:
   - type: textarea
     id: description
     attributes:
       label: "Description"
-      description: Please enter an explicit description of your issue
-      placeholder: Short and explicit description of your incident...
-    validations:
-      required: true
-  - type: input
-    id: reprod-url
-    attributes:
-      label: "Branch Name"
-      description: Please enter the branch / link to fork
-      placeholder: ex. 'dev' or https://github.com/USERNAME/REPO-NAME
-    validations:
-      required: false
-  - type: textarea
-    id: reprod
-    attributes:
-      label: "Reproduction steps"
-      description: Please enter an explicit description of your issue
       value: |
-        1. Go to '...'
-        2. Click on '....'
-        3. Scroll down to '....'
-        4. See error
-      render: bash
+        Define the problem.
+
+        Capture the setup:
+        * Which branch and git hash used
+        * Any changes in configuration
+
+        Steps to recreate:
+        * ...
+
+        Add logs or screenshots as desired.
+                
     validations:
       required: true
-  - type: textarea
-    id: screenshot
-    attributes:
-      label: "Screenshots"
-      description: If applicable, add screenshots to help explain your problem.
-      value: |
-        ![DESCRIPTION](LINK.png)
-      render: bash
-    validations:
-      required: false
-  - type: textarea
-    id: logs
-    attributes:
-      label: "Logs"
-      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
-      render: bash
-    validations:
-      required: false
+  
   - type: dropdown
     id: os
     attributes:
       label: "OS"
-      description: What is the impacted environment ?
+      description: What is the impacted environment?
       multiple: true
       options:
         - Windows (Direct Clone)
@@ -66,4 +37,8 @@ body:
         - Mac (Direct Clone)
         - Mac (Shared Folders)
     validations:
-      required: true
+      required: false
+
+  - type: markdown
+    attributes:
+      value: "Optional: Please apply any labels or types as necessary - leave blank for unknown."

.github/ISSUE_TEMPLATE/2-FEATURE_REQUEST.yml

@@ -1,23 +1,22 @@
-name: "💡 Feature Request"
-description: Create a new ticket for a new feature request
-title: "💡 [REQUEST] - <title>"
+name: "Feature Request"
+description: Create a new ticket for a new request
 labels: [
-  "question"
+  "NewIssue"
 ]
 body:
-  - type: textarea
-    id: summary
+  - type: markdown
     attributes:
-      label: "Summary"
-      description: Provide a brief explanation of the feature
-      placeholder: Describe in a few lines your feature request
-    validations:
-      required: true
+      value: "Please add a short descriptive title to feature request."
   - type: textarea
-    id: basic_example
+    id: description
     attributes:
-      label: "Use Case"
-      description: Indicate here some basic examples of your feature.
-      placeholder: A few specific words about your feature request.
+      label: "Description"
+      value: |
+        Provide details related to the new feature.
+                
+      render: bash  
     validations:
       required: true
+  - type: markdown
+    attributes:
+      value: "Optional: Please apply any labels or types as necessary - leave blank for unknown."

.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

@@ -0,0 +1,9 @@
+Summary of PR goals.
+
+How to test?
+* ...
+
+Submodule PRs and actions prior to closing this:
+* ...
+
+Closes #issue.

.github/pull_request_template.md

@@ -6,11 +6,15 @@ on:
 env:
   CTEST_OUTPUT_ON_FAILURE: true
 
+permissions:
+  contents: write
+  id-token: write
+
 jobs:
     fsw:
       runs-on: ubuntu-latest
       container:
-        image: ivvitc/nos3-64:20250124
+        image: ivvitc/nos3-64:20250514
       steps:
         - uses: actions/checkout@v4
           with:
@@ -26,7 +30,7 @@ jobs:
     sim:
       runs-on: ubuntu-latest
       container:
-        image: ivvitc/nos3-64:20250124
+        image: ivvitc/nos3-64:20250514
       steps:
         - uses: actions/checkout@v4
           with:
@@ -40,7 +44,7 @@ jobs:
     coverage:
       runs-on: ubuntu-latest
       container:
-        image: ivvitc/nos3-64:20250124
+        image: ivvitc/nos3-64:20250514
       steps:
         - uses: actions/checkout@v4
           with:
@@ -54,18 +58,19 @@ jobs:
           run: apt-get install -y gcc lcov gcovr bc
         - name: config
           run: make config
-        - name: build-test
+        - name: build coverage docs
           run: |
             export CFLAGS="-fprofile-arcs -ftest-coverage -g"
             make build-test
-            make test-fsw
+            make gcov
+        - name: Upload coverage reports to Codecov
+          uses: codecov/codecov-action@v5
+          with:
+            token: ${{ secrets.CODECOV_TOKEN }}
+            verbose: true
+            recurse_submodules: true
         - name: Archive Coverage Directory
           uses: actions/upload-artifact@v4
           with:
             name: coverage-artifacts
-            path: docs/coverage
-        - name: Upload coverage reports to Codecov
-          uses: codecov/codecov-action@v5
-          with:
-            token: 040717d0-b624-470e-be41-d08720135088
-    
+            path: docs/coverage

.github/workflows/build.yml

@@ -10,6 +10,7 @@ __pycache__
 # Build Files
 #
 build
+*.gcov
 *.o
 support/nos3_install.log
 tmp
@@ -28,5 +29,8 @@ cam.jpg
 #
 # Documentation
 #
+docs/coverage/coverage_report.*
 docs/wiki/_build
 docs/wiki/_templates
+*.bkp
+*.html

.gitignore

@@ -156,3 +156,7 @@
 	path = gsw/yamcs
 	url = https://github.com/nasa-itc/yamcs-nos3.git
 	branch = main
+[submodule "components/mgr"]
+	path = components/mgr
+	url = https://github.com/nasa-itc/mgr.git
+	branch = main

.gitmodules

@@ -19,7 +19,7 @@ Government Agency Original Software Title:
 User Registration Requested. Please Visit 
   https://github.com/nasa/nos3
 Government Agency Point of Contact for Original Software:
-  John.P.Lucas@nasa.gov
+  Justin.R.Morris@nasa.gov
 
 1. DEFINITIONS