Skip to content

Feature/historical conditions#8148

Open
jvigliotta wants to merge 91 commits intomasterfrom
feature/historical-conditions
Open

Feature/historical conditions#8148
jvigliotta wants to merge 91 commits intomasterfrom
feature/historical-conditions

Conversation

@jvigliotta
Copy link
Copy Markdown
Contributor

@jvigliotta jvigliotta commented Aug 26, 2025

Closes #8082
Closes #8083

Describe your changes:

Adds the ability to evaluate conditions historically.

Majority of the work completed by @khalidadil

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta jvigliotta removed the request for review from Mattral March 17, 2026 23:22
Copy link
Copy Markdown
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more questions and comments.

@jvigliotta jvigliotta requested a review from shefalijoshi March 24, 2026 22:36
Copy link
Copy Markdown
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Something is wrong with the condition set output when 2 DIFFERENT condition sets are included in a display layout they seem to emit the same output. Even if the expected outputs are different. To reproduce: 1. Create a SWG SWGSmall with a value range of -1 to +1. 2. Create another SWG SWGLarge with a value range of 0 - 20. 3. Create a condition set with a default condition and a 2nd condition where SWGSmall's Sine value > 1 (this should never happen, so it should only output the default output) 4. Create a condition set with a default condition and a 2nd condition where SWGLarge's Sine value > 0 (this CAN happen, so it should NEVER output tte default value) 5. Drag both condition sets into a display layout. 6. Note that both condition sets (alpha numerics) show the same outputs.

@jvigliotta jvigliotta requested a review from shefalijoshi April 7, 2026 22:43
@jvigliotta
Copy link
Copy Markdown
Contributor Author

Image Something is wrong with the condition set output when 2 DIFFERENT condition sets are included in a display layout they seem to emit the same output. Even if the expected outputs are different. To reproduce: 1. Create a SWG SWGSmall with a value range of -1 to +1. 2. Create another SWG SWGLarge with a value range of 0 - 20. 3. Create a condition set with a default condition and a 2nd condition where SWGSmall's Sine value > 1 (this should never happen, so it should only output the default output) 4. Create a condition set with a default condition and a 2nd condition where SWGLarge's Sine value > 0 (this CAN happen, so it should NEVER output tte default value) 5. Drag both condition sets into a display layout. 6. Note that both condition sets (alpha numerics) show the same outputs.

So, this was due to an item that was used for output, being removed and the outputTelemetry was not cleared, so it was referencing an item that was removed from the composition, this has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rodap type:feature Feature. Required intentional design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support a mode where Condition Sets emit the underlying telemetry value when true Support conditional evaluation of historical telemetry

6 participants