-
Notifications
You must be signed in to change notification settings - Fork 1.3k
8184 couch requests views failing #8185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Reference telemetry map as a Map, not associative array * Only normalize once * Another cheeky createNormalizedDatum * Fix unit tests that were broken by removal of createNormalizedDatum * Fixed failing test
20fbf7c to
3550046
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8185 +/- ##
=======================================
Coverage 57.20% 57.20%
=======================================
Files 704 704
Lines 28283 28282 -1
Branches 2770 2770
=======================================
+ Hits 16179 16180 +1
+ Misses 11760 11758 -2
Partials 344 344
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Seems straightforward.
Closes #8184
NEEDS CHERRY-PICK TO GOLD
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist