fix: hide remove container btn when only one container exists#8272
Open
dcpagotto wants to merge 1 commit intonasa:masterfrom
Open
fix: hide remove container btn when only one container exists#8272dcpagotto wants to merge 1 commit intonasa:masterfrom
dcpagotto wants to merge 1 commit intonasa:masterfrom
Conversation
Author
|
Hey, just checking in on this one. Is there anything else I should change or add to get this reviewed? I tried to keep the changes minimal and added the e2e test to cover the scenario. Let me know if theres something missing or if you need me to rebase on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
when there was only one container left in flexible layout
confusing for users
containers.length > 1
Test plan
Closes #7274