1964 methods return size one pointers#1965
Draft
excaliburtb wants to merge 10 commits intonasa:masterfrom
Draft
Conversation
excaliburtb
commented
Jan 21, 2026
| size_t len = strlen(reference_name); | ||
| size_t rem = (size_t)256 - len; | ||
| snprintf(&reference_name[len], rem, "[%d]", my_index[j]); | ||
| size_t rem = 256 - len; |
Contributor
Author
There was a problem hiding this comment.
need to check that len isn't greater than 256 (which needs a const size_t MAX_LENGTH = 256; or something like that to eliminate the magic number. if it's greater it'll wrap and become a huge integer value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1964