Skip to content

Conversation

@Jiangshan00001
Copy link

the changelog:

  1. add memory support for sapi.
    eg:
b = BytesIO()
engine.save_to_file('i am Hello World', b)
engine.runAndWait()
  1. fix VoiceAge key error

  2. fix for sapi save_to_file when it run on machine without outputsream device.

Hunta88 and others added 30 commits November 20, 2021 22:25
under describe:: finished-utterance
"...have the folowing signature." was changed to "...have the following signature."
fix `VoiceAge` not found error
Fix typo in Documentation
…device.

fix for sapi save_to_file when it run on machine without outputsream device.
…device.

fix for sapi save_to_file when it run on machine without outputsream device.
nsss save_to_file no content error fix
remove six.py and use six package instead
Import super from objc to fix AttributeError
@nateshmbhat
Copy link
Owner

been away for quite some time now. can you please see if you can spend some time to resolve the merge conflicts ?

@willwade
Copy link
Collaborator

@nateshmbhat its not going to merge at all as its really referring to pyttsx4. But that aside I think voiceAge error and save_to_file when it run on machine without outputsream device is now fixed.

Im super intrigued about the memory support idea. Really @Jiangshan00001 was just wanting bytes back. I'll happily do a PR on this bit alone..

  • Do we want it streaming or only on completion?
  • Can you imagine a need for callbacks?

i.e. do we save_to_bytestream (like save to file) or do we save_to_bytestream and allow connect to work with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants