Skip to content

Cells support#391

Open
jurrick wants to merge 2 commits intonathanvda:masterfrom
jurrick:cells_support
Open

Cells support#391
jurrick wants to merge 2 commits intonathanvda:masterfrom
jurrick:cells_support

Conversation

@jurrick
Copy link
Copy Markdown

@jurrick jurrick commented Oct 19, 2016

Fixes #315

@nathanvda
Copy link
Copy Markdown
Owner

Thanks. This is not a huge priority for me. As I have no experience with cells, also a bit hard to confirm this works. Also no documentation is added, so without documentation nobody will know how to use it.

I have to do some catch-up with all the open issues/PR's first 😄

Not sure if this is the best approach, an alternative approach would be to split this up in two gems, where I include your changes to ViewHelpers so it can be overridden, and a cocoon-cells gem (or cells-cocoon, whichever makes more sense) where the CellsHelper lives, with specific documentation.

I hope to find some time this weekend to work on cocoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants