Fix jQuery deprecation issue

[vilius]

Uses $() syntax instead $(document).on("ready") which removes deprecation warning as of jQuery 1.8 and fixes the script for jQuery 3, where the method is removed.

See:
https://jquery.com/upgrade-guide/3.0/#breaking-change-on-quot-ready-quot-fn-removed
https://api.jquery.com/ready/#entry-longdesc

[nathanvda]

Mmmmmm. I think this is not correct and I do not have a simple way to fix it. The "ready page:load" events are both replaced by the "turbolinks:load" event. So this works perfectly fine for backwards compatibility (if you use the new turbolinks). Indeed, if someone does not use turbolinks it will no longer be triggered. But someone using turbolinks 5 will, with your code, call hideRemoveFields twice.

[vilius]

Hi @nathanvda

I'm not sure if I understood why it should not work, but I don't have much experience with Turbolinks. To my understanding:

$(hideRemoveFields); // On page load

^ This will get executed on page load once regardless if turbolinks is used or not.

$(document).on('page:load turbolinks:load', hideRemoveFields); // On custom load events

^ This will get executed only when Turbolinks are used (either old version or the new one). It will get executed on initial load and subsequent turbolink-loads of body content.

Thus when Turbolinks is used the hideRemoveFields code will get executed twice on initial load. However it should not have any side effects.

Actually maybe this could be even better implementation:

  $(function() {
    hideRemoveFields();
    $(document).on('page:load turbolinks:load', hideRemoveFields); // Turbolinks support
  });

This will work with all jQuery versions. It will also work with Turbolinks and the code will be executed once per page load (either initial or one initiated by Turbolinks).

Am I missing something?

[nathanvda]

Thank you for your work (and fixing the documentation 👍 👏 👏). But if possible, I prefer to maintain backward compatibility. So not sure what the best approach is to achieve that, and if it is possible.

[nathanvda]

Hi there: I would want to merge this, but you have not yet updated the code as you mentioned in your last comment, which looks just fine (sorry I forgot to reply back to you earlier).

Also, with regards to the documentation you are confused: the synthetic event ready is deprecated, but not the ready() call, it is still supported, see https://api.jquery.com/ready/ so the README is correct (and I prefer the more verbose version, so the documentation as it is now). So I would love to merge this if it only contained the code-change as discussed before.