Conversation
This function no longer applies due to changes in how DataStore handles GPS point visibility
|
Oops hold off on merging this @RobLBaker - I've confused myself with the arcticdatautils stuff and just saw that you made similar changes in another unmerged PR |
Merge branch 'main' into sarah-dev # Conflicts: # NEWS.md # R/optional_eml_elements.R # R/required_eml_elements.R # R/tabular_data_congruence.R
|
Also just did what I think will add links for bug reports and source code to the pkgdown site, in response to comments in JOSS review |
| nps <- EMLeditor::get_eml_simple(metadata, "byOrForNPS") | ||
| missing_nps <- is.null(nps) | ||
| #error if no by or for nps | ||
| if (missing_nps) { |
There was a problem hiding this comment.
I thought we were using the tidyverse style guide? That includes spaces between the if and the conditional statement and between the end of the conditional statement and the opening curly brace:
There was a problem hiding this comment.
Oh cool, I'm not actually sure how that happened. A lot of stuff in DPchecker needs to be restyled so I'll just do the whole package while I'm at it. I've got other things I need to do this morning, but should have it pushed later today.
There was a problem hiding this comment.
Just ran styler on the whole package, should be ✨ very tidy ✨ now
RobLBaker
left a comment
RobLBaker
left a comment
There was a problem hiding this comment.
All of the actual code changes look great, but it looks like you reverted back away from tidyverse style guide by removing spaces in the opening lines of 'if' statements. See: https://style.tidyverse.org/syntax.html
RobLBaker
left a comment
RobLBaker
left a comment
There was a problem hiding this comment.
Looks great - resolved conflicts and good to merge!
2 participants
Remove test_public_points and remove arcticdatautils dependency (replace with equivalent fxn from EMLeditor).
I changed the version number to 1.1.0. If that seems reasonable, we may want to do a 1.0.1 release before merging this pr. (Do we usually do github releases for minor versions? If not, disregard).
Closes #157