add function test_datatable_url_attributes#172
Merged
RobLBaker merged 15 commits intonationalparkservice:mainfrom Apr 25, 2025
Merged
add function test_datatable_url_attributes#172RobLBaker merged 15 commits intonationalparkservice:mainfrom
test_datatable_url_attributes#172RobLBaker merged 15 commits intonationalparkservice:mainfrom
Conversation
… function = download or function = information tags in the xml.
…s for tes_datatable_urls, test_datatable_urls_doi, and test_datatable_url_attributes
… about new unit tests.
wright13
reviewed
Apr 24, 2025
.gitignore
Outdated
Comment on lines
+2
to
+5
| .Rhistorygood_dir <- test_path("good") | ||
| bad_dir <- test_path("bad") | ||
| bicy_meta <- load_metadata(test_path("good", "BICY_good")) | ||
| buis_meta <- load_metadata(test_path("good", "BUIS_good")) |
Collaborator
There was a problem hiding this comment.
Looks like this might have been mistakenly pasted here?
Member
Author
There was a problem hiding this comment.
Oh yeah, not sure how that happened... hold on...
wright13
reviewed
Apr 24, 2025
R/tabular_data_congruence.R
Outdated
| suffix <- stringr::str_sub(url, -7, -1) | ||
|
|
||
| if(!prefix == "https://irma.nps.gov/DataStore/Reference/Profile/") { | ||
| cli::cli_warn(c("!" = "One or more data table URL attributes in metadata is set to \"informatoion\" but the URL supplied is not a DataStore reference profile. Please check that the URL goes to the appropriate page and it is not a direct download link for the data file.")) |
wright13
requested changes
Apr 24, 2025
Collaborator
wright13
left a comment
wright13
left a comment
There was a problem hiding this comment.
Looks good, I found one typo that needs to be fixed but I think you're good to merge after that
wright13
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add unit tests for
test_datatable_urls,test_datatable_urls_doiandtest_datatable_url_attributesCloses #171