New Function Added To Get Columns From Files#106
Open
iquevedo123 wants to merge 9 commits intonationalparkservice:masterfrom
Open
New Function Added To Get Columns From Files#106iquevedo123 wants to merge 9 commits intonationalparkservice:masterfrom
iquevedo123 wants to merge 9 commits intonationalparkservice:masterfrom
Conversation
Member
|
Thanks Issac! I may not be able to review this until after the upcoming Botany meetings (so late June). Sorry for the delay. |
RobLBaker
reviewed
May 31, 2024
Member
There was a problem hiding this comment.
I'm wondering if this should be called get_column_names() rather than get_columns_from_files() as I think it returns the column names, not the columns themselves (and update associated documentation to clarify this point)
RobLBaker
requested changes
Jun 24, 2024
Member
RobLBaker
left a comment
RobLBaker
left a comment
There was a problem hiding this comment.
Can this all be updated to something like "get_column_names" or "get_column_headers"? The function doesn't actually return the columns themselves, so the name "get_columns_from_files" is a bit misleading/confusing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New function added to get all columns from each csv provided. Function can also find common columns (those that appear more than once across your csv's). Documentation written up, GitHub site updated, News page updated, checks applied, and lintr checks ran. No unit tests written (not too well-versed in writing unit tests).