Conversation
to11mtm
reviewed
Oct 7, 2024
| { | ||
| throw new OperationCanceledException(); | ||
| } | ||
| await _semLock.Writer.WriteAsync(0, cancellationToken).AsTask().WaitAsync(_defaultCommandTimeout, cancellationToken).ConfigureAwait(false); |
Collaborator
There was a problem hiding this comment.
I think a problem you may run into here is that due to the semantics of WaitAsync(), the operation may have cancelled due to timeout -but- the operation could still go through.
Work-around should be to use a CancellationTokenSource.LinkedTokenSource(cancellationToken) and then CancelAfter() on that before passing that token into the WriteAsync()... Just need to dispose the LTS when done
Replaced WaitAsync with CancellationTokenSource for more precise control over command timeouts. This ensures that operations are cancelled correctly after the default timeout and improves overall reliability when handling cancellation tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.