nats server check credential --context-credential#1313
Open
philpennock wants to merge 1 commit intonats-io:mainfrom
Open
nats server check credential --context-credential#1313philpennock wants to merge 1 commit intonats-io:mainfrom
philpennock wants to merge 1 commit intonats-io:mainfrom
Conversation
A common use-case for checking credentials is "check my current credentials". Rather than force users to manually grab the path from their context, provide a flag `--context-credential` to just use the credential from that. Changes in existing behavior: a different error flow for missing `--credential` when this new flag is not given. I couldn't see a way in the fisk library to have a mandatory mutually-exclusive flag group, so coded up the checks manually when dropping `Required()` from `--credential`.
philpennock
force-pushed
the
pdp/check-credential-context
branch
from
432e16f to
19b7b1a
Compare
Member
Author
|
(force-push was an amend to fix a typo in the commit message, no change to tree) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A common use-case for checking credentials is "check my current credentials". Rather than force users to manually grab the path from their context, provide a flag
--context-credentialto just use the credential from that.Changes in existing behavior: a different error flow for missing
--credentialwhen this new flag is not given.I couldn't see a way in the fisk library to have a mandatory mutually-exclusive flag group, so coded up the checks manually when dropping
Required()from--credential.