Add json output to nats kv ls command#1552
Open
justenstall wants to merge 1 commit intonats-io:mainfrom
Open
Conversation
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
ripienaar
reviewed
Nov 5, 2025
| ls.Flag("names", "Show just the bucket names").Short('n').UnNegatableBoolVar(&c.listNames) | ||
| ls.Flag("verbose", "Show detailed info about the key").Short('v').UnNegatableBoolVar(&c.lsVerbose) | ||
| ls.Flag("display-value", "Display value in verbose output (has no effect without 'verbose')").UnNegatableBoolVar(&c.lsVerboseDisplayValue) | ||
| ls.Flag("json", "Produce JSON output").Short('j').UnNegatableBoolVar(&c.json) |
Collaborator
There was a problem hiding this comment.
not really keen on adding our own json representations here for info and keys the nats.go library doesn't have them, we risk inventing something here thats not compatible with future nats.go
So it would be fine for ls that just shows names - but not for info and the extended versions of ls
So if we can rescope this down to just the short ls output and then suggest you open issue with nats.go to add marshaller interfaces to the kv (and obj) data structures, once those have a standard method we can use them here
Author
There was a problem hiding this comment.
That makes sense, I'll open an issue in nats.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--jsonflag to thenats kv lscommand to format the output as JSON.